This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
support setting boolean environment variables #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were previously stored as a string if they are derived from the environment or configuration files. Rather than altering each of the checks, we can select a list of settings to convert to boolean values when they are accessed.
|
Seems legit. Thanks! |
indirect
added a commit
that referenced
this pull request
Feb 19, 2013
support setting boolean environment variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously stored as a string if they are derived from the
environment or configuration files. Rather than altering each of the checks,
we can select a list of settings to convert to boolean values when they are
accessed.
I bumped into this specific problem trying to override
bundle config --global frozen truewith aBUNDLE_FROZEN=falseenvironment variable.